Skip to content

Document capture#6457

Merged
peggles2 merged 18 commits intomainfrom
document-confirm
Jun 17, 2022
Merged

Document capture#6457
peggles2 merged 18 commits intomainfrom
document-confirm

Conversation

@peggles2
Copy link
Copy Markdown
Contributor

@peggles2 peggles2 commented Jun 6, 2022

Create API request for document capture.

POST api/verify/v2/document_capture

Example request:
{
'encryption_key': ‘...’,
'front_image_iv': ‘...’,
'back_image_iv': ‘...’,
'selfie_image_iv': ‘...’,
'front_image_url': ‘...’,
'back_image_url': ‘...’,
'selfie_image_url: ‘...',
'flow_path': '...',
}

Comment thread app/controllers/api/verify/base_controller.rb Outdated
@peggles2 peggles2 force-pushed the document-confirm branch from 34c66c1 to 8045f1d Compare June 6, 2022 14:45
Comment thread app/controllers/api/verify/document_capture_controller.rb Outdated
Comment thread spec/controllers/api/verify/document_capture_controller_spec.rb Outdated
Comment thread app/services/idv/actions/verify_document_action.rb Outdated
Comment thread app/controllers/api/verify/document_capture_controller.rb Outdated
@peggles2 peggles2 force-pushed the document-confirm branch from dc0abb4 to 02081ec Compare June 7, 2022 15:23
Comment thread app/controllers/api/verify/document_capture_controller.rb Outdated
Comment thread app/controllers/api/verify/document_capture_controller.rb Outdated
Comment thread app/controllers/api/verify/document_capture_controller.rb Outdated
@peggles2 peggles2 requested review from aduth and zachmargolis June 7, 2022 20:23
Comment thread app/controllers/api/verify/document_capture_controller.rb Outdated
@peggles2 peggles2 force-pushed the document-confirm branch from 490c3aa to 92fb465 Compare June 8, 2022 14:16
Comment thread app/controllers/api/verify/document_capture_controller.rb Outdated
@peggles2 peggles2 requested a review from zachmargolis June 8, 2022 19:29
Copy link
Copy Markdown
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments. Only "blocker"-ish item is making sure we're not double-logging idv_doc_auth_submitted_image_upload_form. Otherwise LGTM 👍

Comment thread app/controllers/api/verify/document_capture_controller.rb Outdated
Comment thread spec/controllers/api/verify/document_capture_controller_spec.rb Outdated
Comment thread app/controllers/api/verify/document_capture_controller.rb Outdated
Comment thread spec/controllers/api/verify/document_capture_controller_spec.rb Outdated
Comment thread spec/controllers/api/verify/document_capture_controller_spec.rb Outdated
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread app/controllers/api/verify/document_capture_controller.rb
Comment thread app/controllers/api/verify/document_capture_controller.rb
@peggles2 peggles2 merged commit c91a0cf into main Jun 17, 2022
@peggles2 peggles2 deleted the document-confirm branch June 17, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants